[CSV-57] CSVParser.getRecords() contract is confusing

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: Parser
• Assignee: Unassigned
• Reporter: Benedikt Ritter
• Created: 12/Mar/12 18:10
• Updated: 29/Mar/12 19:27
• Resolved: 29/Mar/12 19:27

Description

CSVParser.getRecords() has a confusing contract. It will return all records from the current position instead of all values in the parsed file. This implies that users will first iterate over the records using the iterator and then call getRecords(). This seems like an unlikely use case.

Also, it is not good practice to return null. So getRecords() should return an empty array, if no records can be found.