Uploaded image for project: 'Commons CSV'
  1. Commons CSV
  2. CSV-57

CSVParser.getRecords() contract is confusing

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Parser
    • Labels:
      None

      Description

      CSVParser.getRecords() has a confusing contract. It will return all records from the current position instead of all values in the parsed file. This implies that users will first iterate over the records using the iterator and then call getRecords(). This seems like an unlikely use case.

      Also, it is not good practice to return null. So getRecords() should return an empty array, if no records can be found.

        Attachments

        1. CSV-57.txt
          2 kB
          Benedikt Ritter

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              britter Benedikt Ritter
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: