Continuum
  1. Continuum
  2. CONTINUUM-2028

Continuum release prepare should use maven-release-plugin scmCommentPrefix configuration in pom

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.2
    • Fix Version/s: 1.3.2 (Beta)
    • Component/s: None
    • Labels:
      None
    • Environment:
      Continuum 1.2.2, Subversion

      Description

      I have a Subversion repository with a pre-commit hook that requires a valid issue tracker id in every commit message.

      The default commit message for release prepare is "[maven-release-manager] prepare for next development iteration" which is not acceptable.

      I tried configuring the scmCommentPrefix for the release plugin in the pom, but the commit message still came out as [maven-release-manager] and was rejected.

        <build>
          <plugins>
            <plugin>
              <artifactId>maven-release-plugin</artifactId>
              <configuration>
                <scmCommentPrefix>[ABCD1234]</scmCommentPrefix>
              </configuration>
            </plugin>
          </plugins>
        </build>
      

        Issue Links

          Activity

          Wendy Smoak created issue -
          Olivier Lamy (*$^¨%`£) made changes -
          Field Original Value New Value
          Fix Version/s 1.3.1 [ 14741 ]
          Hide
          Wendy Smoak added a comment -

          While I'd love to see this fixed, I don't want to load up 1.3.1 with more than absolutely necessary.

          This seems to be a larger problem than this one config element – see CONTINUUM1633, CONTINUUM-1503, CONTINUUM-1504, CONTINUUM-1505 which all point to different release plugin config being ignored.

          Show
          Wendy Smoak added a comment - While I'd love to see this fixed, I don't want to load up 1.3.1 with more than absolutely necessary. This seems to be a larger problem than this one config element – see CONTINUUM1633, CONTINUUM-1503 , CONTINUUM-1504 , CONTINUUM-1505 which all point to different release plugin config being ignored.
          Wendy Smoak made changes -
          Link This issue is related to CONTINUUM-1633 [ CONTINUUM-1633 ]
          Wendy Smoak made changes -
          Link This issue is related to CONTINUUM-1503 [ CONTINUUM-1503 ]
          Wendy Smoak made changes -
          Link This issue is related to CONTINUUM-1504 [ CONTINUUM-1504 ]
          Wendy Smoak made changes -
          Link This issue is related to CONTINUUM-1505 [ CONTINUUM-1505 ]
          Hide
          Olivier Lamy (*$^¨%`£) added a comment - - edited

          Ok.
          We can try to fix that for 1.2.3
          Will you have time to test this ? (because testing the release through UI need times).

          Show
          Olivier Lamy (*$^¨%`£) added a comment - - edited Ok. We can try to fix that for 1.2.3 Will you have time to test this ? (because testing the release through UI need times).
          Hide
          Wendy Smoak added a comment -

          Yes I have time to test it. If you've got a fix in mind already, go for it – on trunk!

          I simply meant I didn't want this to block a 1.3.1 release once we have the database upgrade issue sorted out. (Fix for 1.3.x instead of 1.3.1, that's all.)

          Show
          Wendy Smoak added a comment - Yes I have time to test it. If you've got a fix in mind already, go for it – on trunk! I simply meant I didn't want this to block a 1.3.1 release once we have the database upgrade issue sorted out. (Fix for 1.3.x instead of 1.3.1, that's all.)
          Maria Odea Ching made changes -
          Fix Version/s 1.3.2 [ 14902 ]
          Fix Version/s 1.3.1 [ 14741 ]
          Hide
          Julien HENRY added a comment -

          It would be great to be able to give the scm comment prefix in the Continuum UI when doing the release. I also have a pre-commit hook in my organisation but the issue tracker is different for each release so it is not a good solution for me to store it in the pom.

          Show
          Julien HENRY added a comment - It would be great to be able to give the scm comment prefix in the Continuum UI when doing the release. I also have a pre-commit hook in my organisation but the issue tracker is different for each release so it is not a good solution for me to store it in the pom.
          Wendy Smoak made changes -
          Link This issue relates to CONTINUUM-2054 [ CONTINUUM-2054 ]
          Hide
          Wendy Smoak added a comment -

          I opened CONTINUUM-2054 for the further enhancement of configuring this through the Web UI.

          Even if the issue key changes for every release, you can still configure it in the pom prior to executing the release process.

          Show
          Wendy Smoak added a comment - I opened CONTINUUM-2054 for the further enhancement of configuring this through the Web UI. Even if the issue key changes for every release, you can still configure it in the pom prior to executing the release process.
          Hide
          Julien HENRY added a comment -

          Thanks for opening the enhancement request.

          The main advantage of releasing through Continuum Web UI is it is not needed to checkout the code source (can be done from a non developer computer). If I have to edit the pom before releasing, I have to checkout/commit so it reduces Continuum usefulness.

          Show
          Julien HENRY added a comment - Thanks for opening the enhancement request. The main advantage of releasing through Continuum Web UI is it is not needed to checkout the code source (can be done from a non developer computer). If I have to edit the pom before releasing, I have to checkout/commit so it reduces Continuum usefulness.
          Hide
          Emmanuel Venisse added a comment -

          Done in r.740906

          Show
          Emmanuel Venisse added a comment - Done in r.740906
          Emmanuel Venisse made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Assignee Emmanuel Venisse [ evenisse ]
          Hide
          Wendy Smoak added a comment -

          This doesn't seem to be working in r740908

          with this in the pom:

          <plugin>
          <artifactId>maven-release-plugin</artifactId>
          <configuration>
          <autoVersionSubmodules>true</autoVersionSubmodules>
          <scmCommentPrefix>[HELLO-455] </scmCommentPrefix>
          </configuration>
          </plugin>

          the commit message was:

          Author: wsmoak
          Date: 2009-02-06 09:35:17 -0600 (Fri, 06 Feb 2009)
          New Revision: 1182

          Modified:
          hello/trunk/pom.xml
          Log:
          [maven-release-manager] prepare release hello-1.1.6

          I also noticed the SCM Comment Prefix on the release prepare page didn't pre-populate with the value in the pom, so it may be related to CONTINUUM-2054.

          I'll modify one of the examples in the sandbox and record a Selenium test to double check.

          Show
          Wendy Smoak added a comment - This doesn't seem to be working in r740908 with this in the pom: <plugin> <artifactId>maven-release-plugin</artifactId> <configuration> <autoVersionSubmodules>true</autoVersionSubmodules> <scmCommentPrefix> [HELLO-455] </scmCommentPrefix> </configuration> </plugin> the commit message was: Author: wsmoak Date: 2009-02-06 09:35:17 -0600 (Fri, 06 Feb 2009) New Revision: 1182 Modified: hello/trunk/pom.xml Log: [maven-release-manager] prepare release hello-1.1.6 I also noticed the SCM Comment Prefix on the release prepare page didn't pre-populate with the value in the pom, so it may be related to CONTINUUM-2054 . I'll modify one of the examples in the sandbox and record a Selenium test to double check.
          Hide
          Emmanuel Venisse added a comment -

          It works fine.

          Show
          Emmanuel Venisse added a comment - It works fine.
          Hide
          Wendy Smoak added a comment -

          It works fine for me at r741756. Thanks for taking a look, Emmanuel. Maybe you fixed it by adding the missing 'get' method?

          Show
          Wendy Smoak added a comment - It works fine for me at r741756. Thanks for taking a look, Emmanuel. Maybe you fixed it by adding the missing 'get' method?
          Hide
          Emmanuel Venisse added a comment -

          Yes probably.

          Show
          Emmanuel Venisse added a comment - Yes probably.
          Mark Thomas made changes -
          Project Import Sun Apr 05 08:36:01 UTC 2015 [ 1428222961749 ]
          Mark Thomas made changes -
          Workflow jira [ 12710679 ] Default workflow, editable Closed status [ 12740343 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 21:12:18 UTC 2015 [ 1428268338676 ]
          Mark Thomas made changes -
          Workflow jira [ 12948487 ] Default workflow, editable Closed status [ 12985745 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Closed Closed
          35d 23h 1 Emmanuel Venisse 04/Feb/09 15:55

            People

            • Assignee:
              Emmanuel Venisse
              Reporter:
              Wendy Smoak
            • Votes:
              2 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development