Apache Cordova
  1. Apache Cordova
  2. CB-147

[PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.4.0
    • Component/s: Android
    • Labels:
      None

      Description

      Two patch files:

      • 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
      • 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window

        Activity

        Hide
        Andrew Lunny added a comment - - edited

        extra patch on top - some error-checking/encapsulation to avoid NullPointerExceptions

        Show
        Andrew Lunny added a comment - - edited extra patch on top - some error-checking/encapsulation to avoid NullPointerExceptions
        Hide
        Andrew Lunny added a comment -

        created pull request on github - https://github.com/cordova/cordova-android/pull/3

        Show
        Andrew Lunny added a comment - created pull request on github - https://github.com/cordova/cordova-android/pull/3
        Hide
        Joe Bowser added a comment -

        This has already been patched, and this will be the way we now handle all preferences in PhoneGap-Android moving forward.

        Show
        Joe Bowser added a comment - This has already been patched, and this will be the way we now handle all preferences in PhoneGap-Android moving forward.
        Hide
        Joe Bowser added a comment -

        Good job Andrew!

        Show
        Joe Bowser added a comment - Good job Andrew!

          People

          • Assignee:
            Joe Bowser
            Reporter:
            Andrew Lunny
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development