Apache Cordova
  1. Apache Cordova
  2. CB-147

[PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.4.0
    • Component/s: Android
    • Labels:
      None

      Description

      Two patch files:

      • 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
      • 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        31d 17h 28m 1 Joe Bowser 02/Feb/12 20:07
        Resolved Resolved Closed Closed
        24s 1 Joe Bowser 02/Feb/12 20:08
        Joe Bowser made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Joe Bowser [ bowserj ]
        Hide
        Joe Bowser added a comment -

        Good job Andrew!

        Show
        Joe Bowser added a comment - Good job Andrew!
        Joe Bowser made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Joe Bowser added a comment -

        This has already been patched, and this will be the way we now handle all preferences in PhoneGap-Android moving forward.

        Show
        Joe Bowser added a comment - This has already been patched, and this will be the way we now handle all preferences in PhoneGap-Android moving forward.
        Hide
        Andrew Lunny added a comment -

        created pull request on github - https://github.com/cordova/cordova-android/pull/3

        Show
        Andrew Lunny added a comment - created pull request on github - https://github.com/cordova/cordova-android/pull/3
        Simon MacDonald made changes -
        Fix Version/s 1.4.0 [ 12319449 ]
        Fix Version/s 1.3.0 [ 12319167 ]
        Andrew Lunny made changes -
        Hide
        Andrew Lunny added a comment - - edited

        extra patch on top - some error-checking/encapsulation to avoid NullPointerExceptions

        Show
        Andrew Lunny added a comment - - edited extra patch on top - some error-checking/encapsulation to avoid NullPointerExceptions
        Andrew Lunny made changes -
        Field Original Value New Value
        Attachment 0001-reading-preferences-from-phonegap.xml.patch [ 12509022 ]
        Attachment 0002-using-preference-fullscreen-for-fullscreen-view.patch [ 12509023 ]
        Andrew Lunny created issue -

          People

          • Assignee:
            Joe Bowser
            Reporter:
            Andrew Lunny
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development