Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-14225

Fix sample namespace Serialize attribute in template/Properties/Default.rd.xml

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: cordova-windows
    • Labels:
      None

      Description

      If I would generate a new UWP C# project using Visual Studio 2017 and copy the generated Default.rd.xml file into template\Properties then I would see the following diff:

      index 7c40ffeb..af00722c 100644
      --- a/template/Properties/Default.rd.xml
      +++ b/template/Properties/Default.rd.xml
      @@ -12,7 +12,7 @@
           <TypeInstantiation Name="App1.AppClass" Arguments="System.Int32" Activate="Required Public" />
      
           Using the Namespace directive to apply reflection policy to all the types in a particular namespace
      -    <Namespace Name="DataClasses.ViewModels" Seralize="All" />
      +    <Namespace Name="DataClasses.ViewModels" Serialize="All" />
       -->
      
       <Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
      

      I propose to commit this change to the master branch.

      Related:

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                brodybits Chris Brody
                Reporter:
                brodybits Chris Brody
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: