Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-14224

template/Properties/Default.rd.xml needs license header

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: cordova-windows
    • Labels:
      None

      Description

      Running coho audit-license-headers -r windows gives a message that template/Properties/Default.rd.xml is missing the license header. From a quick search I found Default.rd.xml in Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml (github) which is exactly the same except for a http link that was updated to https (update: old http link in GitHub, no need to update this one). I would like to propose the following changes:

      Additional notes:

      • template/Properties/Default.rd.xml was introduced in CB-12499.
      • I raised Microsoft/Windows-universal-samples#949 to cleanup (and rename) its LICENSE file. This may influence the exact LICENSE text we should include in template/Properties/Default.rd.xml.
      • Another fix to template/Properties/Default.rd.xml is proposed in CB-14225

        Attachments

          Activity

            People

            • Assignee:
              brodybits Chris Brody
              Reporter:
              brodybits Chris Brody
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: