Details
-
Bug
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
Description
Running coho audit-license-headers -r windows gives a message that template/Properties/Default.rd.xml is missing the license header. From a quick search I found Default.rd.xml in Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml (github) which is exactly the same except for a http link that was updated to https (update: old http link in GitHub, no need to update this one). I would like to propose the following changes:
Updated https link from Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml (github)- Include license text from Microsoft / Windows-universal-samples / LICENSE (github) (with left alignment fixed)
- Link to Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml (github) in template/Properties/Default.rd.xml
Additional notes:
- template/Properties/Default.rd.xml was introduced in
CB-12499. - I raised Microsoft/Windows-universal-samples#949 to cleanup (and rename) its LICENSE file. This may influence the exact LICENSE text we should include in template/Properties/Default.rd.xml.
- Another fix to template/Properties/Default.rd.xml is proposed in
CB-14225