[CB-12738] cordova ignores plugin dependency version

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: cordova-cli, cordova-lib
• Labels: cordova-next
• Assignee: Nikita Matrosov
• Reporter: Marcus Pridham
• Created: 28/Apr/17 16:15
• Updated: 23/Aug/18 06:43
• Resolved: 02/Jun/17 20:44

Description

You can see this with the cordova-plugin-file-transfer. When you install this plugin and it installs the cordova-plugin-file plugin dependency the CLI writes
Fetching plugin "cordova-plugin-file" via npm

The first problem is in the PluginInfo _parseDependency function
https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-common/src/PluginInfo/PluginInfo.js;h=48174707b0dbf6f60eb65faeb14c51e4b3868b1b;hb=HEAD#l108

It does not parse out the dependency version. This part:

        var dep =
            { id : tag.attrib.id
            , url : tag.attrib.url || ''
            , subdir : tag.attrib.subdir || ''
            , commit : tag.attrib.commit
            };

Should be:

        var dep =
            { id : tag.attrib.id
            , url : tag.attrib.url || ''
            , subdir : tag.attrib.subdir || ''
            , commit : tag.attrib.commit
            , version : tag.attrib.version
            };

The second problem is in the plugman installDependency method
https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-lib/src/plugman/install.js;h=fca77c688d2b8f19ce63cb176f50ecd44c9a9032;hb=HEAD#l603

The dep_src is only constructed using the plugin id.

This:

var dep_src = dep.url.length ? dep.url : dep.id;

Should look something like:

        var dep_src;

        if (dep.url.length) {
            dep_src = dep.url;
        }
        else if (dep.version) {
            dep_src = dep.id + '@' + dep.version;
        } else {
            dep_src = dep.id;
        } 

With these changes the Cordova CLI correctly reports:

Fetching plugin "cordova-plugin-file@^4.0.0" via npm

Issue Links

• is related to: CB-12867 cordova-compat dependent version is not match between latest released plugins
• links to: GitHub Pull Request #554