[CAY-2801] Incorrect equals() implementation in IdGenerationMarker could cause data missing in the commit

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 4.2.RC2
• Fix Version/s: 4.2, 5.0-M1
• Component/s: Core Library
• Assignee: Nikita Timofeev
• Reporter: Nikita Timofeev
• Created: 09/Mar/23 08:34
• Updated: 10/Mar/23 09:16
• Resolved: 10/Mar/23 09:15

Description

IdGenerationMarker class uses parent id hash as a data source for the equals() method.
This could cause severe problems like data missing in the commit in case of the hash collision in two ids and usage of the OpIdFactory.ReplacementAwareObjectId id implementation.

There's already a commit that is part of CAY-2777 fix, that significantly reduces risk of this problem:
https://github.com/apache/cayenne/commit/53c9408e026d926601baf6e68b9761489c273397

See also this mail thread: https://lists.apache.org/thread/2hdsn7vzdbbsgzvjt9mxwxkfo81m79wq

Issue Links

• is caused by: CAY-2777 Reverse relationship is not set with single table inheritance