[CAY-2777] Reverse relationship is not set with single table inheritance

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2.RC1
• Fix Version/s: 4.2.RC2, 5.0-M1
• Assignee: Nikita Timofeev
• Reporter: Andrus Adamchik
• Created: 17/Nov/22 15:20
• Updated: 13/Jun/24 11:56
• Resolved: 22/Nov/22 13:37

Description

Given the model:

// a table with a many to many to self
T1: id, type
T11: child_id, parent_id; 

// Base ObjEntity
O1: 
  - flat rel "parents" mapped as "db:parents.parent"

// Sub ObjEntity 1
O1S1:
  - flat rel "children" mapped as "db:children.child"

// Sub ObjEntity 2
O1S2:

O1S1 parent = ...
O1S2 child = ...

// THE PROBLEM IS HERE
// This fails to set "parents" relationship of O1S2
parent.addToChildren(child);

The culprit seems to be "ObjRelationship.getReverseRelationship()", specifically this check here

for (ObjRelationship relationship : target.getRelationships()) {

            // TODO: this should be replaced with inheritance-aware code. 
            // "relationship.getTargetEntity()" should be allowed to be a 
            // super entity of source
            if (relationship.getTargetEntity() != source) {
                continue;
            }

Issue Links

• causes: CAY-2801 Incorrect equals() implementation in IdGenerationMarker could cause data missing in the commit