[CASSANDRA-3986] Cli shouldn't call FBU.getBroadcastAddress needlessly

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 1.0.9, 1.1.0
• Severity: Normal
• Assignee: Brandon Williams
• Reporter: Brandon Williams

Authors

Brandon Williams

Reviewers

Dave Brosius

• Created: 01/Mar/12 16:19
• Updated: 16/Apr/19 09:32
• Resolved: 01/Mar/12 16:34

Description

The cli is calling this, which causes yaml to be loaded, but the broadcast address isn't needed.

            // adding default data center from SimpleSnitch
            if (currentStrategyOptions == null || currentStrategyOptions.isEmpty())
            {
                SimpleSnitch snitch = new SimpleSnitch();
                Map<String, String> options = new HashMap<String, String>();
                options.put(snitch.getDatacenter(FBUtilities.getBroadcastAddress()), "1");

                ksDef.setStrategy_options(options);
            }

because SimpleSnitch always returns 'datacenter1'