Cassandra
  1. Cassandra
  2. CASSANDRA-3986

Cli shouldn't call FBU.getBroadcastAddress needlessly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 1.0.9, 1.1.0
    • Component/s: Core
    • Labels:
      None

      Description

      The cli is calling this, which causes yaml to be loaded, but the broadcast address isn't needed.

                  // adding default data center from SimpleSnitch
                  if (currentStrategyOptions == null || currentStrategyOptions.isEmpty())
                  {
                      SimpleSnitch snitch = new SimpleSnitch();
                      Map<String, String> options = new HashMap<String, String>();
                      options.put(snitch.getDatacenter(FBUtilities.getBroadcastAddress()), "1");
      
                      ksDef.setStrategy_options(options);
                  }
      

      because SimpleSnitch always returns 'datacenter1'

      1. 3986.txt
        0.7 kB
        Brandon Williams

        Activity

        Gavin made changes -
        Workflow patch-available, re-open possible [ 12749585 ] reopen-resolved, no closed status, patch-avail, testing [ 12754309 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12655516 ] patch-available, re-open possible [ 12749585 ]
        Brandon Williams made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Reviewer dbrosius@apache.org
        Resolution Fixed [ 1 ]
        Brandon Williams made changes -
        Field Original Value New Value
        Attachment 3986.txt [ 12516695 ]
        Brandon Williams created issue -

          People

          • Assignee:
            Brandon Williams
            Reporter:
            Brandon Williams
            Reviewer:
            Dave Brosius
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development