Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-3986

Cli shouldn't call FBU.getBroadcastAddress needlessly

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • 1.0.9, 1.1.0
    • None
    • None
    • Normal

    Description

      The cli is calling this, which causes yaml to be loaded, but the broadcast address isn't needed.

                  // adding default data center from SimpleSnitch
                  if (currentStrategyOptions == null || currentStrategyOptions.isEmpty())
                  {
                      SimpleSnitch snitch = new SimpleSnitch();
                      Map<String, String> options = new HashMap<String, String>();
                      options.put(snitch.getDatacenter(FBUtilities.getBroadcastAddress()), "1");
      
                      ksDef.setStrategy_options(options);
                  }
      

      because SimpleSnitch always returns 'datacenter1'

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            brandon.williams Brandon Williams Assign to me
            brandon.williams Brandon Williams
            Brandon Williams
            Dave Brosius
            Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment