[CASSANDRA-19960] CommitLogArchiver in CommitLog should be final (19448 follow-up)

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.15, 4.1.8, 5.0.2, 5.1
• Component/s: Local/Commit Log
• Bug Category: Code - Bug - Unclear Impact
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/63cad45bfc74c2d3a3705bc64398742e76bef136

Test and Documentation Plan

mutliplexing changed test

• Assignee: Stefan Miklosovic
• Reporter: Stefan Miklosovic

Authors

Stefan Miklosovic

Reviewers

Caleb Rackliffe

• Created: 27/Sep/24 09:38
• Updated: 30/Sep/24 12:24
• Resolved: 27/Sep/24 12:17

Description

This is follow-up for CASSANDRA-19448, we made CommitLogArchiver non-final but not volatile. This might cause issues. We just need to return it back to final and remove the setter. The fact it is non-final now is because it was more comfortable to write tests but there is not any reason to keep it like that if tests are rewritten a little bit.

Issue Links

• links to: GitHub Pull Request #3581