[CASSANDRA-19448] CommitlogArchiver only has granularity to seconds for restore_point_in_time - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 4.0.14, 4.1.7, 5.0.1, 5.1
Component/s: Local/Commit Log
Labels:
None

Bug Category:
Correctness - Recoverable Corruption / Loss
Severity:
Normal
Complexity:
Normal
Discovered By:
User Report
Platform:

All
Impacts:

None
Since Version:

NA
Source Control Link:

https://github.com/apache/cassandra/commit/9f18aab1dcbc40bb038fdcbad15c5bcd40909819
Test and Documentation Plan:

Hide

UT

Show
UT

Description

Commitlog archiver allows users to backup commitlog files for the purpose of doing point in time restores. The configuration file gives an example of down to the seconds granularity but then asks what whether the timestamps are microseconds or milliseconds - defaulting to microseconds. Because the CommitLogArchiver uses a second based date format, if a user specifies to restore at something at a lower granularity like milliseconds or microseconds, that means that the it will truncate everything after the second and restore to that second. So say you specify a restore_point_in_time like this:
restore_point_in_time=2024:01:18 17:01:01.623392
it will silently truncate everything after the 01 seconds. So effectively to the user, it is missing updates between 01 and 01.623392.

This appears to be a bug in the intent. We should allow users to specify down to the millisecond or even microsecond level. If we allow them to specify down to microseconds for the restore point in time, then it may internally need to change from a long.