[CASSANDRA-19040] Consider CONTAINS KEY in SAI unindexed index contexts

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-beta1, 5.0, 5.1
• Component/s: Feature/SAI
• Epic Link: Storage Attached Indexes (Phase 2)
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Normal
• Complexity: Normal
• Discovered By: Unit Test
• Platform: All
• Since Version: 5.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/c26f2a3d6936d6ff2f14c6ab19b3727c2f86c941

Test and Documentation Plan

PR	CI
5.0	j11 j17
trunk	j11 j17

• Assignee: Andres de la Peña
• Reporter: Andres de la Peña

Authors

Andres de la Peña

Reviewers

Maxwell Guo, Michael Semb Wever

• Created: 20/Nov/23 15:10
• Updated: 05/Dec/23 12:51
• Resolved: 23/Nov/23 12:04

Description

As reported by CASSANDRA-19034, SelectTest#testContainsKeyAndContainsWithIndexOnMapValue fails when the default config uses SAI:

[junit-timeout] Testcase: testContainsKeyAndContainsWithIndexOnMapValue(org.apache.cassandra.cql3.validation.operations.SelectTest)-_jdk11:	FAILED
[junit-timeout] Got less rows than expected. Expected 1 but got 0
[junit-timeout] junit.framework.AssertionFailedError: Got less rows than expected. Expected 1 but got 0
[junit-timeout] 	at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1849)
[junit-timeout] 	at org.apache.cassandra.cql3.validation.operations.SelectTest.lambda$testContainsKeyAndContainsWithIndexOnMapValue$9(SelectTest.java:625)
[junit-timeout] 	at org.apache.cassandra.cql3.CQLTester.beforeAndAfterFlush(CQLTester.java:2238)
[junit-timeout] 	at org.apache.cassandra.cql3.validation.operations.SelectTest.testContainsKeyAndContainsWithIndexOnMapValue(SelectTest.java:618)
[junit-timeout] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit-timeout] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[junit-timeout] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[junit-timeout] 
[junit-timeout] 

This can also be reproduced with this simple test:

createTable("CREATE TABLE %s (k int PRIMARY KEY, v int, m map<int,int>)");
createIndex("CREATE INDEX ON %s(v) USING 'SAI'");
execute("INSERT INTO %s (k, v, m) VALUES (?, ?, ?)", 0, 1, map(2, 3));
assertRows(execute("SELECT k, v, m FROM %s WHERE v = 1 AND m CONTAINS KEY 2 ALLOW FILTERING"),
           row(0, 1, map(2, 3)));

I think the problem is that the index context created by the query planner for an unindexed column always has a VALUES index target type, here. This is problematic when there is a CONTAINS KEY expression that isn't backed by an index, since we'll be comparing the searched map key to scanned map values.

Issue Links

• is a child of: CASSANDRA-19034 SelectTest fails when run with SAI index
• links to: GitHub Pull Request #2922
• links to: GitHub Pull Request #2925