[CASSANDRA-19034] SelectTest fails when run with SAI index

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-beta1, 5.0, 5.1
• Component/s: Feature/SAI
• Epic Link: Storage Attached Indexes (Phase 2)
• Bug Category: Correctness
• Severity: Normal
• Complexity: Normal
• Discovered By: Unit Test
• Platform: All
• Since Version: 5.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/a9e6ed37874f2240039086309e7849bea42c07e2

Test and Documentation Plan

Latest CI runs are in the comments

• Assignee: Mike Adamson
• Reporter: Branimir Lambov

Authors

Mike Adamson

Reviewers

Andres de la Peña, Michael Semb Wever

• Created: 17/Nov/23 15:06
• Updated: 27/Nov/23 19:32
• Resolved: 26/Nov/23 11:39

Description

When run with SAI index, the following two tests error out:

[junit-timeout] Testcase: testContainsKeyAndContainsWithIndexOnMapValue(org.apache.cassandra.cql3.validation.operations.SelectTest)-_jdk11:	FAILED
[junit-timeout] Got less rows than expected. Expected 1 but got 0
[junit-timeout] junit.framework.AssertionFailedError: Got less rows than expected. Expected 1 but got 0
[junit-timeout] 	at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1849)
[junit-timeout] 	at org.apache.cassandra.cql3.validation.operations.SelectTest.lambda$testContainsKeyAndContainsWithIndexOnMapValue$9(SelectTest.java:625)
[junit-timeout] 	at org.apache.cassandra.cql3.CQLTester.beforeAndAfterFlush(CQLTester.java:2238)
[junit-timeout] 	at org.apache.cassandra.cql3.validation.operations.SelectTest.testContainsKeyAndContainsWithIndexOnMapValue(SelectTest.java:618)
[junit-timeout] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit-timeout] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[junit-timeout] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[junit-timeout] 
[junit-timeout] 
[junit-timeout] Testcase: testFilterWithIndexForContains(org.apache.cassandra.cql3.validation.operations.SelectTest)-_jdk11:	FAILED
[junit-timeout] Invalid value for row 1 column 0 (k1 of type int), expected <1> but got <0>
[junit-timeout] Invalid value for row 1 column 2 (v of type set<int>), expected <{4, 5, 6}> but got <{2, 3, 4}>
[junit-timeout] 
[junit-timeout] junit.framework.AssertionFailedError: Invalid value for row 1 column 0 (k1 of type int), expected <1> but got <0>
[junit-timeout] Invalid value for row 1 column 2 (v of type set<int>), expected <{4, 5, 6}> but got <{2, 3, 4}>
[junit-timeout] 
[junit-timeout] 	at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1826)
[junit-timeout] 	at org.apache.cassandra.cql3.validation.operations.SelectTest.lambda$testFilterWithIndexForContains$6(SelectTest.java:543)
[junit-timeout] 	at org.apache.cassandra.cql3.CQLTester.beforeAndAfterFlush(CQLTester.java:2240)
[junit-timeout] 	at org.apache.cassandra.cql3.validation.operations.SelectTest.testFilterWithIndexForContains(SelectTest.java:542)
[junit-timeout] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit-timeout] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[junit-timeout] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

The latter seems to be giving the results in the wrong order, and the order flips when the data is flushed.

Caught during preparation of _latest config that would switch default to SAI (CASSANDRA-18753).

Issue Links

• Discovered while testing: CASSANDRA-18753 Add an optimized default configuration to tests and make it available for new users
• is a parent of: CASSANDRA-19040 Consider CONTAINS KEY in SAI unindexed index contexts
• links to: GitHub Pull Request #2929
• links to: GitHub Pull Request #2930