[CASSANDRA-18166] Improve the code model around IndexContext

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-beta1, 5.0, 5.1
• Component/s: Feature/SAI
• Labels: SAI
• Epic Link: Storage Attached Indexes (Phase 2)
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/0e42b77c9735d1124fe0a5766447f29c891cdb5b

Test and Documentation Plan

CircleCI runs are in the comments

• Assignee: Mike Adamson
• Reporter: Mike Adamson

Authors

Mike Adamson

Reviewers

Andres de la Peña, Caleb Rackliffe

• Created: 16/Jan/23 13:58
• Updated: 27/Nov/23 19:32
• Resolved: 25/Nov/23 09:13

Description

We currently have a situation where we need to create an IndexContext that is for a non-indexed column and therefore is never going to be used for indexing or searching. This results in the IndexContext having to check for this at points in the code with assertions. The reason for this that, even when the column is non-indexed, we need to have information about the column for the purpose of post-filtering.

It would make sense to split out the column / index information needed for filtering from the indexing / searching requirements such that we could avoid unnecessary assertions in the code.

Issue Links

• contains: CASSANDRA-18994 SAI range query does not play together with "IN"
• contains: CASSANDRA-18590 Introduce IndexTermType to replace TypeUtils in SAI
• is duplicated by: CASSANDRA-18994 SAI range query does not play together with "IN"
• is related to: CASSANDRA-19084 Test Failure: IndexStreamingFailureTest.testAvailabilityAfterFailed*EntireFileStreaming
• links to: GitHub Pull Request #2916
• links to: GitHub Pull Request #2917