[CASSANDRA-17992] Upgrade Netty on 5.0

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Dependencies
• Epic Link: Support Java 17
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/53d1644ff4142f4383a773408c142c34954063f5

Test and Documentation Plan

Run CI and check regressions; check release notes

• Assignee: Jacek Lewandowski
• Reporter: Ekaterina Dimitrova

Authors

Ekaterina Dimitrova, Jacek Lewandowski

Reviewers

Berenguer Blasi, Ekaterina Dimitrova

• Created: 26/Oct/22 01:19
• Updated: 24/Sep/23 22:26
• Resolved: 03/Aug/23 22:16

Description

I haven't been able to identify from the Netty docs which was the lowest version where JDK17 was added but we are about 40 versions behind in netty 4 so I suspect we better update. 

We need to consider there was an issue with class cast exceptions when building with JDK17 with newer versions of netty (the newest available in March 2022). For the record, we didn't see those when running CI on JDK8 and JDK11. We also need to carefully revise the changes between the netty versions. --> CASSANDRA-18180

Upgrading will cover also a fix in netty that was discussed in this ASF Slack thread. 

CC benedict , aleksey 

Issue Links

• Dependency: CASSANDRA-12787 Reduce instanceOf() type checking to improve performance
• is blocked by: CASSANDRA-18247 Add CircleCI config files for J11+J17
• is related to: CASSANDRA-18729 Remove unnecessary Netty dependencies after upgrade to 4.1.96
• Testing discovered: CASSANDRA-18180 bulkLoaderSuccessfullyStreamsOverSsl fails with ClassCastException on JDK17
• Testing discovered: CASSANDRA-18690 Fix the way we produce a DTest jar
• links to: apache/cassandra-dtest/trunk PR
• links to: apache/cassandra/trunk PR
• links to: GitHub Pull Request #2493
• links to: GitHub Pull Request #2551