[CASSANDRA-18690] Fix the way we produce a DTest jar

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Build
• Bug Category: Correctness
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 5.0

Source Control Link

https://github.com/apache/cassandra/commit/c1bf002234bd44bce120658e9b08b3d67901e5bb, https://github.com/apache/cassandra/commit/738dfde73560d289218f3afa4103a37e9f401757

Test and Documentation Plan

I pulled jlewandowski's patch here - https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:18690-trunk

CI running here - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2435/workflows/70ab8457-dcea-411d-abd8-6dd598b63393

• Assignee: Jacek Lewandowski
• Reporter: Ekaterina Dimitrova

Authors

Jacek Lewandowski

Reviewers

Brandon Williams, Ekaterina Dimitrova

• Created: 25/Jul/23 14:31
• Updated: 12/Sep/23 13:03
• Resolved: 27/Jul/23 08:16

Description

The problem is related to how we produce the dtest jar. That repackages all dependencies along with our classes in a single jar. Some dependencies might have digital signatures extracted into META-INF as, say, *.SF files. We need to remove them because they are invalid for the uber-jar we produce. Therefore, there are exclusions in zipgroupfileset operations, more or less like this:

<zipgroupfileset dir="${build.lib}" includes="*.jar" excludes="META-INF/*.SF"/>

However, this does not work as expected. The exclude attribute denotes jar files we don't want to repackage rather than filter on the content of the jar file. The new BouncyCastle jars include signatures in SF and DSA files, which all land in the final dtest.jar regardless of that filter.

See also https://stackoverflow.com/questions/35577351/exclude-jar-from-ant-build-using-zipgroupfileset/35593838#35593838

The issue was discovered and explained by jlewandowski in CASSANDRA-17992

Issue Links

• Discovered while testing: CASSANDRA-17992 Upgrade Netty on 5.0
• links to: GitHub Pull Request #2515