[CASSANDRA-17677] Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1, 5.0-alpha1, 5.0
• Component/s: Tool/bulk load
• Bug Category: Correctness
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.1-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/83c169ec9e36324f27bf562951362f4a03c3c688

Test and Documentation Plan

PR available here: https://github.com/apache/cassandra/pull/1658

• Assignee: Francisco Guerrero
• Reporter: Ekaterina Dimitrova

Authors

Francisco Guerrero

Reviewers

Ekaterina Dimitrova, Yifan Cai

• Created: 01/Jun/22 17:11
• Updated: 12/Sep/23 13:03
• Resolved: 19/Aug/22 21:27

Description

entire_sstable_stream_throughput_outbound and entire_sstable_inter_dc_stream_throughput_outbound were introduced in CASSANDRA-17065.They were added to the LoaderOptions class but they are not loaded in BulkLoader as throttle and interDcThrottle are. As part of this ticket we need to fix the BulkLoader, also those properties should be advertised as MiB/s, not megabits/s. This was not changed in CASSANDRA-15234 for the bulk loader because those are not loaded and those variables in LoaderOptions are disconnected from the Cassandra config parameters and unused at the moment. 
It will be good also to update the doc here - https://cassandra.apache.org/doc/latest/cassandra/operating/bulk_loading.html,
and add a test that those are loaded properly when used with the BulkLoader. 
CC frankgh 

Issue Links

• relates to: CASSANDRA-17065 Introduce separate rate limiting settings for entire SSTable streaming
• Testing discovered: CASSANDRA-17817 Fix upgrade test test_collection_function on trunk
• Testing discovered: CASSANDRA-17843 Fix test/distributed/org/apache/cassandra/distributed/test/IncRepairCoordinatorErrorTest