[CASSANDRA-15234] Standardise config and JVM parameters

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Local/Config
• Bug Category: Correctness
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/db9f7a67ec4b03413c10034956e2cf18739ca4b1

Test and Documentation Plan

CCM patch committed here and retagged.

DTest patch committed here

Trunk patch split to 13 patches starts from this one on.

The existing tests plus new unit tests added. Also, dtests exercise the backward compatibility and test that way that ccm supports the same behavior as Cassandra as regards to configuration parameters loading. 

Docs in review - CASSANDRA-17246

• Assignee: Ekaterina Dimitrova
• Reporter: Benedict Elliott Smith

Authors

Ekaterina Dimitrova

Reviewers

Benjamin Lerer, Caleb Rackliffe, David Capwell, Michael Semb Wever

• Created: 17/Jul/19 07:32
• Updated: 24/Jan/23 19:23
• Resolved: 06/Feb/22 03:56

Description

We have a bunch of inconsistent names and config patterns in the codebase, both from the yams and JVM properties. It would be nice to standardise the naming (such as otc_ vs internode_) as well as the provision of values with units - while maintaining perpetual backwards compatibility with the old parameter names, of course.

For temporal units, I would propose parsing strings with suffixes of:

code
u|micros(econds?)?
ms|millis(econds?)?
s(econds?)?
m(inutes?)?
h(ours?)?
d(ays?)?
mo(nths?)?
code

For rate units, I would propose parsing any of the standard B/s, KiB/s, MiB/s, GiB/s, TiB/s.
Perhaps for avoiding ambiguity we could not accept bauds bs, Mbps or powers of 1000 such as KB/s, given these are regularly used for either their old or new definition e.g. KiB/s, or we could support them and simply log the value in bytes/s.

Issue Links

• blocks: CASSANDRA-17166 Enhance SnakeYAML properties to be reusable outside of YAML parsing, support camel case conversion to snake case, and add support to ignore properties
• duplicates: CASSANDRA-15146 Transitional TLS server configuration options are overly complex
• is duplicated by: CASSANDRA-17074 Remove custom Duration object and refactor its usages to use Duration from Java
• is related to: CASSANDRA-17574 Throw exception on wrong config boundaries
• is related to: CASSANDRA-17141 internode_send_buff_size_in_bytes and internode_recv_buff_size_in_bytes from cassandra.yaml
• is related to: CASSANDRA-17243 Fix BYTES_PER_MEGABIT in StreamManager
• is related to: CASSANDRA-17148 Adapt track_warnings to Guardrails
• is related to: CASSANDRA-9691 Liberate cassandra.yaml parameter names from their units
• is related to: CASSANDRA-16152 In-JVM dtest - modify schema with stopped nodes and use yaml fragments for config
• is related to: CASSANDRA-17160 Emit warnings for deprecated parameters (changed names) only once
• is related to: CASSANDRA-17379 Fail starting when the same parameter exists more than once in cassandra.yaml
• is related to: CASSANDRA-17949 Update CCM post CASSANDRA-17379
• is related to: CASSANDRA-17246 DOCS - Update changed config + JVM, guide post CASSANDRA-15234
• is related to: CASSANDRA-17431 Move the rest of the Config parameters to the new Config framework
• relates to: CASSANDRA-17135 Update docs for CASSANDRA-17132
• relates to: CASSANDRA-15146 Transitional TLS server configuration options are overly complex
• relates to: CASSANDRA-17118 coordinator_large_read should be actually coordinator_read_size in cassandra.yaml
• relates to: CASSANDRA-17131 Fix formatting in cassandra.yaml
• relates to: CASSANDRA-17132 Fix startup issue with internode_application_timeout_in_ms
• relates to: CASSANDRA-16038 Add a getter for InstanceConfig parameters - in-jvm-dtests-api
• links to: CCM
• links to: DTest
• links to: Trunk