[CASSANDRA-17668] Fix leak of non-standard Java types in our Exceptions as clients using JMX are unable to handle them

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Legacy/Observability, Observability/JMX
• Bug Category: Correctness
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/e5c9cf4cbe6634ba9e148b6e27b6bad98648e597

Test and Documentation Plan

Test using JConsole and added new unit tests

• Assignee: Leonard Ma
• Reporter: Ekaterina Dimitrova

Authors

Leonard Ma

Reviewers

David Capwell, Ekaterina Dimitrova

• Created: 27/May/22 18:30
• Updated: 12/Sep/23 13:02
• Resolved: 26/Sep/22 15:43

Description

This is a continuation of CASSANDRA-17638 where we fixed leaks introduced during development of 4.1 to ensure no regressions.

This ticket is to fix a few leakages which are there since previous major versions, not 4.1 regressions. 

setRepairSessionMaxTreeDepth(exists since 3.0) and setRepairSessionSpaceInMegabytes(since 4.0)

 in the DatabaseDescriptor. 

checkValidForByteConversion and validateMaxConcurrentAutoUpgradeTasksConf (both since 4.0)

 are used in both setters and on startup. They shouldn't throw ConfigurationException in the setters. 

There might be more but those are at least a few obvious I found in the DatabaseDescriptor.

CC dcapwell 

Issue Links

• relates to: CASSANDRA-17638 Clients using JMX are unable to handle non-standard java types but we leak this into our Exceptions