Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-17638

Clients using JMX are unable to handle non-standard java types but we leak this into our Exceptions

    XMLWordPrintableJSON

Details

    • Correctness
    • Normal
    • Low Hanging Fruit
    • User Report
    • All
    • None
    • Hide
      PR CI
      4.1 j8, j11
      trunk j8, j11

      The current tests. 

      While fixing the exceptions I noticed we didn't remove a validation not needed anymore which makes just an additional empty read of the cassandra.yaml without a need anymore. I did it in this commit.

      Some context: 
      IsBlank is redundant when we have commitlog_sync_period and commitlog_sync_group_window default to 0ms and not 0, that was enough to prevent from the issue with allowing empty value in the yaml
      I added a new test to confirm we didn't break anything. Unfortunately, the test failed in CI as I didn't commit the last fix I had for it.I added the commit now but not rerunning full CI for that one. There are two other tests with known unrelated failures.

      Show
      PR CI 4.1 j8, j11 trunk j8,   j11 The current tests.  While fixing the exceptions I noticed we didn't remove a validation not needed anymore which makes just an additional empty read of the cassandra.yaml without a need anymore. I did it in this commit . Some context:  IsBlank is redundant when we have commitlog_sync_period and commitlog_sync_group_window default to 0ms and not 0, that was enough to prevent from the issue with allowing empty value in the yaml I added a new test to confirm we didn't break anything. Unfortunately, the test failed in CI as I didn't commit the last fix I had for it.I added the commit now but not rerunning full CI for that one. There are two other tests with known unrelated failures.

    Description

      This is follow up ticket on CASSANDRA-17527 and CASSANDRA-17580.
      CASSANDRA-17580 was decided to be a backup non-default option for users who want to be 100% sure there are no leaked Cassandra exceptions. In that sense I will fix here all known ConfigurationExceptions that need to be thrown as IllegalArgumentException for the default behavior as we were always supposed to do that.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. CASSANDRA-17668 Fix leak of non-standard Java types in our Exceptions as clients using JMX are unable to handle them

          • Normal -
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CASSANDRA-17527 Clients using JMX are unable to handle non-standard java types but we leak this into our interfaces

          • Normal -
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. CASSANDRA-17580 Clients using JMX are unable to handle non-standard java types but we leak this into our Exceptions

          • Normal -
          • Open

          Activity

            People

              e.dimitrova Ekaterina Dimitrova
              e.dimitrova Ekaterina Dimitrova
              Ekaterina Dimitrova
              David Capwell, Ekaterina Dimitrova
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: