[CASSANDRA-16759] Avoid memoizing the wrong min cluster version during upgrades

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-rc2, 4.0, 4.0.1
• Component/s: Consistency/Coordination
• Bug Category: Degradation - Other Exception
• Severity: Critical
• Complexity: Challenging
• Discovered By: DTest
• Platform: All
• Since Version: 4.0-rc1

Source Control Link

https://github.com/apache/cassandra/commit/2fba5c80ce7bf71d04c62043ffa1088b9e832d83

Test and Documentation Plan

cci run

• Assignee: Marcus Eriksson
• Reporter: Marcus Eriksson

Authors

Jon Meredith, Marcus Eriksson

Reviewers

Brandon Williams, Yifan Cai

• Created: 23/Jun/21 15:19
• Updated: 01/Aug/21 11:33
• Resolved: 27/Jun/21 05:17

Description

CASSANDRA-16525 avoids trying to calculate the cluster min version if gossiper is not enabled.

This makes us memoize the wrong version for up to a minute causing us to send 4.0-messages to 3.0 nodes, for example in ColumnFilter

This was discovered by python upgrade dtests, here after reverting CASSANDRA-15899 in CASSANDRA-16735