[CASSANDRA-16735] Adding columns via ALTER TABLE can generate corrupt sstables

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.25, 3.11.11, 4.0-rc2, 4.0
• Component/s: Consistency/Repair, Local/SSTable
• Bug Category: Correctness - Unrecoverable Corruption / Loss
• Severity: Critical
• Complexity: Normal
• Discovered By: Fuzz Test
• Platform: All
• Since Version: 3.0.23

Source Control Link

https://github.com/apache/cassandra/commit/1d87da3f6fc0eca4e805238c19db16e6607b44a7

Test and Documentation Plan

new test, cci run

• Assignee: Marcus Eriksson
• Reporter: Marcus Eriksson

Authors

Marcus Eriksson

Reviewers

Alex Petrov, Sam Tunnicliffe

• Created: 11/Jun/21 17:51
• Updated: 14/Oct/21 12:11
• Resolved: 21/Jun/21 14:00

Description

This is similar to CASSANDRA-13004 and was caused by CASSANDRA-15899

Basically the column placeholders introduced in 15899 can get read-repaired in to the memtable and later flushed to disk and in some cases this can conflict with the actual column (if the actual column is a collection for example) and cause CorruptSSTableExceptions.

Fix is probably to just revert 15899, at least until if and when we find a solution that we can rely on. Will post that + test next week.

Issue Links

• causes: CASSANDRA-16770 Avoid sending cdc column in serialization header to 3.0 nodes