[CASSANDRA-16185] Add tests to cover CommitLog metrics

• Type: Improvement
• Status: Patch Available
• Priority: Normal
• Resolution: Unresolved
• Fix Version/s: 4.0.x
• Component/s: Test/unit
• Epic Link: 40_Quality_Test
• Change Category: Quality Assurance
• Complexity: Normal

Test and Documentation Plan

CommitLogMetrics Test-CasesCommitLogMetrics Test-Cases

 

1.  For below metrics, test-case are added in CommitLogTest.java . In test-cases, mutations are added, which internally update metrics. 

• completedTasks
• totalCommitLogSize
• waitingOnCommit

 

2. pendingTasks - In AbstractCommitLogService.java , added testPendingTasks test-case,  since pendingTasks metric are incremented and decremented in single method of  AbstractCommitLogService::maybeWaitForSync .

So introduced a dummy method incrementPendingTaks in  FakeCommitLogService-class, to manually update pendingTasks metric.

 

3. waitingOnSegmentAllocation - In CommitLogMetricsTest.java test-case is added. In test commitlog_segment_size_in_mb is changed to 1mb, and adding multiple  mutations so that waitingOnSegmentAllocation metric updated while creating new segments.

In normal case , waitingOnSegmentAllocation it will be zero, if during test-execution, waitingOnSegmentAllocation was not updated, then manually updating it.

• Assignee: Berenguer Blasi
• Reporter: Benjamin Lerer

Authors

Berenguer Blasi, Yasar Arafath Baigh

Reviewers

Adam Holmberg, Berenguer Blasi

• Created: 06/Oct/20 09:11
• Updated: 02/Jul/21 13:07

Description

The only metrics that seems to be covered by unit test for the CommitLog metrics is oversizedMutations. We should add testing the other ones.

Issue Links

• is a child of: CASSANDRA-15582 4.0 quality testing: metrics
• links to: circle ci build - unit test reports
• links to: Git PR : https://github.com/yasarbaigh/cassandra/pull/4