[CASSANDRA-15909] Make Table/Keyspace Metric Names Consistent With Each Other

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta3, 4.0
• Component/s: Observability/Metrics
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/ce6af5aad66347942132a99ec640b99edf94f614

Test and Documentation Plan

no additional tests - documentation will be updated on CASSANDRA-15821 once this merges.

• Assignee: Caleb Rackliffe
• Reporter: Stephen Mallette

Authors

Caleb Rackliffe, Stephen Mallette

Reviewers

Caleb Rackliffe, David Capwell, Dinesh Joshi

• Created: 30/Jun/20 14:19
• Updated: 25/Jan/21 22:39
• Resolved: 09/Sep/20 18:36

Description

As part of CASSANDRA-15821 it became apparent that certain metric names found in keyspace and tables had different names but were in fact the same metric - they are as follows:

• Table.SyncTime == Keyspace.RepairSyncTime
• Table.RepairedDataTrackingOverreadRows == Keyspace.RepairedOverreadRows
• Table.RepairedDataTrackingOverreadTime == Keyspace.RepairedOverreadTime
• Table.AllMemtablesHeapSize == Keyspace.AllMemtablesOnHeapDataSize
• Table.AllMemtablesOffHeapSize == Keyspace.AllMemtablesOffHeapDataSize
• Table.MemtableOnHeapSize == Keyspace.MemtableOnHeapDataSize
• Table.MemtableOffHeapSize == Keyspace.MemtableOffHeapDataSize

Also, client metrics are the only metrics to start with a lower case letter. Change those to upper case to match all the other metrics.

Unifying this naming would help make metrics more consistent as part of CASSANDRA-15582

Issue Links

• is a child of: CASSANDRA-15582 4.0 quality testing: metrics
• is depended upon by: CASSANDRA-15821 Metrics Documentation Enhancements
• relates to: CASSANDRA-16090 Remove Legacy ColumnFamily Aliases from TableMetrics