[CASSANDRA-15788] Add tests to cover CacheMetrics

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta2, 4.0
• Component/s: Test/unit
• Change Category: Quality Assurance
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/0d99470f154a86c74665fed5f33a65ef146c4c31

Test and Documentation Plan

additional unit tests

• Assignee: Stephen Mallette
• Reporter: Stephen Mallette

Authors

Stephen Mallette

Reviewers

Michael Semb Wever

• Created: 05/May/20 14:11
• Updated: 03/Jan/21 17:02
• Resolved: 19/Aug/20 14:54

Description

CacheMetrics and ChunkCacheMetrics do not have unit tests covering them. CachingBench seems to provide some coverage but those tests (which don't appear to run as part of the standard run of unit tests) are failing and do not assert against all defined metrics, nor do they seem to assert code in InstrumentingCache which also incremented metrics.

Issue Links

• is a child of: CASSANDRA-15582 4.0 quality testing: metrics