[CASSANDRA-15163] Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha2, 4.0
• Component/s: Messaging/Internode
• Change Category: Semantic
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/f9ff88437742675db5c53f5834884b43f8937e00

Test and Documentation Plan

N/A

• Assignee: Aleksey Yeschenko
• Reporter: Aleksey Yeschenko

Authors

Aleksey Yeschenko

Reviewers

Blake Eggleston

• Created: 14/Jun/19 20:37
• Updated: 25/Feb/21 23:21
• Resolved: 20/Sep/19 22:54

Description

There is currently a nested sub-hierarchy of messages used by repair - in RepairMessage - all sharing one verb, all sharing one deserialiser, all sharing one verb handler. The first two can and should be addressed, and it’s mostly a mechanical task to do so. The last one should be tackled separately, when we get to refactor repair some day (and it could definitely use some love).

The proposed patch follows-up the work done in CASSANDRA-15066 and makes repair use the new messaging service in a more correct way, making verbs and deserialization more explicit. It wasn't included into the original commit so that to not make the single commit larger that it needed to be.

Issue Links

• causes: CASSANDRA-16469 replication_test.TestReplication.test_network_topology failure