[CASSANDRA-15066] Improvements to Internode Messaging

• Type: Improvement
• Status: Resolved
• Priority: High
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Messaging/Internode
• Change Category: Quality Assurance
• Complexity: Challenging

Source Control Link

310a48efcfdc0fb77fbd5fd6e734bf17667f617d

Test and Documentation Plan

https://cwiki.apache.org/confluence/display/CASSANDRA/4.0+Internode+Messaging+Test+Plan

• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Aleksey Yeschenko, Benedict Elliott Smith

Reviewers

Aleksey Yeschenko, Alex Petrov, Benedict Elliott Smith

• Created: 26/Mar/19 00:56
• Updated: 17/Dec/22 23:45
• Resolved: 12/Jun/19 15:16

Description

CASSANDRA-8457 introduced asynchronous networking to internode messaging, but there have been several follow-up endeavours to improve some semantic issues. CASSANDRA-14503 and CASSANDRA-13630 are the latest such efforts, and were combined some months ago into a single overarching refactor of the original work, to address some of the issues that have been discovered. Given the criticality of this work to the project, we wanted to bring some more eyes to bear to ensure the release goes ahead smoothly. In doing so, we uncovered a number of issues with messaging, some of which long standing, that we felt needed to be addressed. This patch widens the scope of CASSANDRA-14503 and CASSANDRA-13630 in an effort to close the book on the messaging service, at least for the foreseeable future.

The patch includes a number of clarifying refactors that touch outside of the net.async package, and a number of semantic changes to the net.async packages itself. We believe it clarifies the intent and behaviour of the code while improving system stability, which we will outline in comments below.

https://github.com/belliottsmith/cassandra/tree/messaging-improvements

Issue Links

• causes: CASSANDRA-17981 Restore internode custom tracing
• contains: CASSANDRA-3017 add a Message size limit
• contains: CASSANDRA-9289 Recover from unknown table when deserializing internode messages
• fixes: CASSANDRA-10619 disallow streaming operations while upgrading
• is duplicated by: CASSANDRA-15088 PagingTest failure on trunk
• is duplicated by: CASSANDRA-15222 BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
• supercedes: CASSANDRA-14575 Reevaluate when to drop an internode connection on message error
• mentioned in: Page Loading...