[CASSANDRA-14540] Internode messaging handshake sends wrong messaging version number

• Type: Bug
• Status: Resolved
• Priority: Urgent
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Legacy/Streaming and Messaging
• Severity: Critical
• Assignee: Jason Brown
• Reporter: Jason Brown

Authors

Jason Brown

Reviewers

Dinesh Joshi

• Created: 23/Jun/18 12:16
• Updated: 15/May/20 08:06
• Resolved: 25/Jun/18 13:42

Description

With the refactor of internode messaging to netty in 4.0, we abstracted the protocol handshakes messages into a class and handlers. There is a bug when the initiator of the connection sends, in the third message of the handshake, it's own default protocol version number (MessagingService.current_version), rather than the negotiated version. This was not causing any obvious problems when CASSANDRA-8457 was initially committed, but the bug is exposed after CASSANDRA-7544. The problem is during rolling upgrades of 3.0/3.X to 4.0, nodes cannot correctly connect.

Issue Links

• is depended upon by: CASSANDRA-14485 Optimize internode messaging protocol