[CASSANDRA-11168] Hint Metrics are updated even if hinted_hand-offs=false

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.6, 3.0.5, 3.5
• Component/s: Legacy/Coordination, Legacy/Observability
• Severity: Low
• Assignee: Anubhav Kale
• Reporter: Anubhav Kale

Authors

Anubhav Kale

Reviewers

Joel Knighton

• Created: 12/Feb/16 22:52
• Updated: 16/Apr/19 09:30
• Resolved: 14/Mar/16 22:09

Description

In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted handoffs.

The reason is StorageProxy.ShouldHint has an inverted if condition.
We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()).

The fix is easy, and I can provide a patch.