Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-11168

Hint Metrics are updated even if hinted_hand-offs=false

    XMLWordPrintableJSON

Details

    • Low

    Description

      In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted handoffs.

      The reason is StorageProxy.ShouldHint has an inverted if condition.
      We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()).

      The fix is easy, and I can provide a patch.

      Attachments

        1. 0001-Hinted-Handoff-Fix.patch
          3 kB
          Anubhav Kale
        2. 0001-Hinted-Handoff-fix-2_2.patch
          2 kB
          Anubhav Kale
        3. 0001-Hinted-handoff-metrics.patch
          3 kB
          Anubhav Kale
        4. 0001-Hinted-handoffs-fix.patch
          3 kB
          Anubhav Kale

        Activity

          People

            anubhavk Anubhav Kale
            anubhavk Anubhav Kale
            Anubhav Kale
            Joel Knighton
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: