[CAMEL-13750] Incoming JMSCorrelationID is passed along when useMessageIDAsCorrelationID

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.24.1
• Fix Version/s: 2.23.4, 2.24.2, 3.0.0.RC1, 3.0.0, 2.25.0
• Component/s: camel-activemq, camel-jms
• Estimated Complexity: Advanced
• Assignee: Andrea Cosentino
• Reporter: Alvin Kwekel
• Created: 16/Jul/19 12:21
• Updated: 08/Nov/19 09:52
• Resolved: 19/Jul/19 08:39

Description

 

+-+            +-+            +-+
| | +-> Q1 +-> | | +-> Q3 +-> | |
|A|            |B|            |C|
| | <-+ Q2 <-+ | | <-+ Q4 <-+ | |
+-+            +-+            +-+

 JMS request goes from A to B to C and the reply back from C to B to A.

A useMessageIDAsCorrelationID=false
B useMessageIDAsCorrelationID=true
C useMessageIDAsCorrelationID=false

The JMSCorrelationID assigned by A is passed along to C via Camel message headers when useMessageIDAsCorrelationID is set on B's request. B is expecting the JMSMessageID to be used as JMSCorrelationID on the reply but since the JMSCorrelationID is actually provided, C could decide to give precedence to the JMSCorrelationID rendering B's message selector to not match.

The only case this would work as expected is when C is also set to useMessageIDAsCorrelationID to always prefer the JMSMessageID. But consider situations where C is not under your control and/or implemented in a different technology than Camel.

I'd argue the JMSCorrelationID should be made null when the useMessageIDAsCorrelationID is set on a provider.

I've created an example project to demonstrate the behavior: https://github.com/alvinkwekel/camel-example-jmscorrelationid

This issue seems to be closely related to https://issues.apache.org/jira/browse/CAMEL-2249

Issue Links

• relates to: CAMEL-14156 JmsBinding assumes endpoint can't be null, but it can
• links to: GitHub Pull Request #3049
• links to: GitHub Pull Request #3061