[CAMEL-14156] JmsBinding assumes endpoint can't be null, but it can

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.24.2
• Fix Version/s: 2.24.3, 3.0.0, 2.25.0
• Component/s: camel-activemq, camel-jms
• Estimated Complexity: Unknown
• Assignee: Jean-Baptiste Onofré
• Reporter: Jean-Baptiste Onofré
• Created: 08/Nov/19 09:49
• Updated: 08/Nov/19 21:47
• Resolved: 08/Nov/19 21:47

Description

CAMEL-13750 introduces a change checking the endpoint in JmsBinding:

if (headerName.equals("JMSCorrelationID") && !endpoint.isUseMessageIDAsCorrelationID()) {

As endpoint can be null (for instance if you just do new JmsBinding()), this change is wrong as it can throw NullPointerException.

I'm fixing.

Issue Links

• blocks: AMQ-7333 Upgrade to Camel 2.24.3
• is related to: CAMEL-13750 Incoming JMSCorrelationID is passed along when useMessageIDAsCorrelationID
• links to: GitHub Pull Request #3328