[CAMEL-10086] Remove Pattern.compile usages

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.20.0
• Component/s: camel-core
• Estimated Complexity: Novice
• Assignee: Claus Ibsen
• Reporter: Mateusz Nowakowski
• Created: 23/Jun/16 08:23
• Updated: 03/Sep/17 08:18
• Resolved: 03/Sep/17 08:18

Description

Please heck Pattern.compile usage across Camel source code - also not direct usage.

For example:
Whenever one of these methods are used from String class a Pattern.compile() is utilized:

• matches
• replaceFirst
• replaceAll
• replace
• split: has an optimization and for certain characters it doesn’t use Pattern.compile.

For example:
GenericFileConsumer.isMatched calls name.matches(endpoint.getExclude())
GenericFileEndpoint could contain also excludePattern as well.

Possible solution:
Walk through the code and replace usages of these methods with static Pattern variables.

Issue Links

• is related to: CAMEL-10085 UnsafeUriCharactersEncoder.checkRAW compiles regex pattern every call
• links to: GitHub Pull Request #1329
• links to: GitHub Pull Request #1332