[CAMEL-10085] UnsafeUriCharactersEncoder.checkRAW compiles regex pattern every call

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.17.1
• Fix Version/s: 2.17.3, 2.18.0
• Component/s: camel-core
• Patch Info: Patch Available
• Estimated Complexity: Novice
• Assignee: Andrea Cosentino
• Reporter: Mateusz Nowakowski
• Created: 23/Jun/16 07:54
• Updated: 05/Jul/16 06:59
• Resolved: 05/Jul/16 06:50

Description

UnsafeUriCharactersEncoder.checkRAW compile regex pattern every time it is called (and it is called really often due to stack:
DefaultCamelContext.normalizeEndpointUri() -> URISUpport.normalizeUri() -> org.apache.camel.util.UnsafeUriCharactersEncoder.encode() -> checkRaw() -> Pattern.compile())

Under high load it leads to decrease performance.

The easiest fix is to precompile pattern:

    private static Pattern RAW_PATTERN = Pattern.compile("RAW\\([^\\)]+\\)");

(....)

    private static List<Pair> checkRAW(String s) {
        Matcher matcher = RAW_PATTERN.matcher(s);
        List<Pair> answer = new ArrayList<Pair>();
        // Check all occurrences
        while (matcher.find()) {
            answer.add(new Pair(matcher.start(), matcher.end()));
        }
        return answer;
    }

Issue Links

• relates to: CAMEL-10086 Remove Pattern.compile usages
• links to: GitHub Pull Request #1059