[CALCITE-6590] Use reflection to handle Java SecurityManager deprecation in Avatica

• Type: Bug
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 1.26.0
• Labels: pull-request-available
• Assignee: Istvan Toth
• Reporter: Julian Hyde
• Created: 20/Sep/24 23:27
• Updated: 31/Oct/24 08:27

Description

Remove use of Java SecurityManager in Avatica.

Running Avatica on JDK 23 (or JRE 23) we get the following runtime errors:

Caused by: java.lang.UnsupportedOperationException: getSubject is supported only if a security manager is allowed at java.base/javax.security.auth.Subject.getSubject(Subject.java:347) at org.apache.calcite.avatica.server.SubjectPreservingPrivilegedThreadFactory.newThread(SubjectPreservingPrivilegedThreadFactory.java:43) 

We were warned - the getSubject method has been deprecated since JDK 18. The deprecation did not cause a build failure, due to CALCITE-5136.

HADOOP-19212 is an issue with the same underlying cause.

The message "getSubject is supported only if a security manager is allowed" implies that another solution would be to enable a security manager (including during tests, and when Avatica is used in Calcite's tests). Should we consider that? If so, please change the case summary.

Issue Links

• is depended upon by: CALCITE-5136 Avatica build (or CI) must fail if there are deprecation warnings
• is depended upon by: CALCITE-6588 Support JDK 23 and Guava 33.3.0 in Avatica
• is depended upon by: CALCITE-6587 Support JDK 23 and Guava 33.3.0
• links to: GitHub Pull Request #250
• links to: GitHub Pull Request #251