[CALCITE-5136] Avatica build (or CI) must fail if there are deprecation warnings

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: avatica-1.26.0
• Assignee: Benchao Li
• Reporter: Julian Hyde
• Created: 06/May/22 19:29
• Updated: 20/Sep/24 23:35

Description

Avatica build (or CI) must fail if there are deprecation warnings.

The build currently gives the following warnings on JDK 18:

core/src/main/java/org/apache/calcite/avatica/remote/DoAsAvaticaHttpClient.java:37: warning: [removal] <T>doAs(Subject,PrivilegedAction<T>) in Subject has been deprecated and marked for removal
    return Subject.doAs(kerberosUtil.getSubject(), new PrivilegedAction<byte[]>() {
                  ^
  where T is a type-variable:
    T extends Object declared in method <T>doAs(Subject,PrivilegedAction<T>)
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning

> Task :server:compileJava
server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:19: warning: [removal] AccessController in java.security has been deprecated and marked for removal
import java.security.AccessController;
                    ^
server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java:204: warning: [removal] <T>doAs(Subject,PrivilegedAction<T>) in Subject has been deprecated and marked for removal
      Subject.doAs(subject, new PrivilegedAction<Void>() {
             ^
  where T is a type-variable:
    T extends Object declared in method <T>doAs(Subject,PrivilegedAction<T>)
server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:43: warning: [removal] AccessController in java.security has been deprecated and marked for removal
    Subject subject = Subject.getSubject(AccessController.getContext());
                                         ^
server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:43: warning: [removal] getSubject(AccessControlContext) in Subject has been deprecated and marked for removal
    Subject subject = Subject.getSubject(AccessController.getContext());
                             ^
server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:46: warning: [removal] <T>doAs(Subject,PrivilegedAction<T>) in Subject has been deprecated and marked for removal
        return Subject.doAs(subject, new PrivilegedAction<Thread>() {
                      ^
  where T is a type-variable:
    T extends Object declared in method <T>doAs(Subject,PrivilegedAction<T>)
server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:44: warning: [removal] AccessController in java.security has been deprecated and marked for removal
    return AccessController.doPrivileged(new PrivilegedAction<Thread>() {

I believe these warnings were introduced in CALCITE-5095.

Must fix before 1.22. We can't allow broken windows in the build.

Issue Links

• depends upon: CALCITE-6590 Use reflection to handle Java SecurityManager deprecation in Avatica
• is depended upon by: CALCITE-6588 Support JDK 23 and Guava 33.3.0 in Avatica
• is depended upon by: CALCITE-6589 Release Avatica 1.26.0
• is related to: CALCITE-5095 Support Java 18 and Guava 31.1-jre