[CALCITE-5167] SqlOperator#rewriteCall does not give accurate validation error

• Type: Improvement
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.30.0
• Component/s: core
• Assignee: Benchao Li
• Reporter: Benchao Li
• Created: 23/May/22 01:20
• Updated: 05/Jun/22 02:43

Description

As discussed in CALCITE-5118, SqlOperator#rewriteCall is done before validation, which is hard to give accurate validation messages. We prefer to use SqlRexConvertlet to do this work, hence we can make the validation error more accurate, and does not give more burden to the optimization phase.

We should deprecate SqlOperator#rewriteCall, and move these rewriting logic to SqlRexConvertlet.

Currently, SqlCoalesceFunction, SqlDatePartFunction, SqlJdbcFunctionCall, SqlNewOperator, SqlNullifFunction, SqlProcedureCallOperator used this mechanism, we should handle these functions in this issue.

Issue Links

• relates to: CALCITE-5118 SqlDatePartFunction#rewriteCall should check operands length