[CALCITE-5118] SqlDatePartFunction#rewriteCall should check operands length

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.30.0
• Fix Version/s: 1.31.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Benchao Li
• Reporter: Benchao Li
• Created: 27/Apr/22 13:42
• Updated: 03/Aug/22 16:21
• Resolved: 25/May/22 08:07

Description

SqlDatePartFunction#rewriteCall does not check operands length for now, and it will be rewrite to EXTRACT unconditionally before validation.

E.g.

select week(); -- will throw ArrayIndexOutOfBoundsException
select week(date '2022-04-27', 1); -- will just ignore second param

However, these cases should throw validation exceptions, because week actually only accept 1 operand.

Issue Links

• is related to: CALCITE-5167 SqlOperator#rewriteCall does not give accurate validation error
• is related to: CALCITE-1606 Add missing support for datetime JDBC functions
• links to: GitHub Pull Request #2782