[CALCITE-4482] "ImmutableBeans.create" has performance issue - ASF JIRA

Rank to Top

Rank to Bottom

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Convert to sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.27.0
Component/s: None
Labels:
- pull-request-available

Description

We are doing the stressing test, and we found SqlNode#toString's time is unusually high, seems the call is all from SqlNode#toString, we can reduce the useless call of "ImmutableBeans.create" to reduce the time:

My proposal is to extra default SqlWriterConfig to SqlNode and SqlNode#toString use this static field.

  public static final SqlWriterConfig DEFAULT_SQL_WRITER_CONFIG =
      SqlPrettyWriter.config().withDialect(AnsiSqlDialect.DEFAULT)
          .withAlwaysUseParentheses(false)
          .withSelectListItemsOnSeparateLines(false)
          .withUpdateSetListNewline(false)
          .withIndentation(0);