[CALCITE-4482] "ImmutableBeans.create" has performance issue

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.27.0
• Labels: pull-request-available
• Assignee: Jiatao Tao
• Reporter: Jiatao Tao
• Created: 01/Feb/21 07:39
• Updated: 03/Jun/21 22:31
• Resolved: 02/Feb/21 18:25

Description

We are doing the stressing test, and we found SqlNode#toString's time is unusually high, seems the call is all from SqlNode#toString, we can reduce the useless call of "ImmutableBeans.create" to reduce the time:

My proposal is to extra default SqlWriterConfig to SqlNode and SqlNode#toString use this static field.

 

  public static final SqlWriterConfig DEFAULT_SQL_WRITER_CONFIG =
      SqlPrettyWriter.config().withDialect(AnsiSqlDialect.DEFAULT)
          .withAlwaysUseParentheses(false)
          .withSelectListItemsOnSeparateLines(false)
          .withUpdateSetListNewline(false)
          .withIndentation(0);

 
 

Issue Links

• links to: GitHub Pull Request #2340