[CALCITE-4234] RelBuilder throws NullPointerException while implementing GROUP_ID()

• Type: Sub-task
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.25.0
• Component/s: core
• Assignee: Julian Hyde
• Reporter: Vladimir Sitnikov
• Created: 06/Sep/20 20:21
• Updated: 02/Feb/21 01:02

Description

RelBuilder throws NullPointerException while implementing GROUP_ID().

CALCITE-4220 introduced the following method:

    @Override public AggregateCall aggregateCall() {
      return AggregateCall.create(aggFunction, distinct, approximate,
          ignoreNulls, ImmutableList.of(), -1, /* collation: */ null, /* type: */ null, alias);
    }

In practice AggregateCall constructor has null checks, so aggregateCall would always throw NPE:

    this.type = Objects.requireNonNull(type);
    this.collation = Objects.requireNonNull(collation);

julianhyde, would you please check if that behavior is expected?

Issue Links

• relates to: CALCITE-4220 In SqlToRelConverter, use RelBuilder for creating Aggregate