Details

    • Sub-task
    • Status: In Progress
    • Major
    • Resolution: Unresolved
    • 1.25.0
    • None
    • core
    • None

    Description

      RelBuilder throws NullPointerException while implementing GROUP_ID().

      CALCITE-4220 introduced the following method:

          @Override public AggregateCall aggregateCall() {
            return AggregateCall.create(aggFunction, distinct, approximate,
                ignoreNulls, ImmutableList.of(), -1, /* collation: */ null, /* type: */ null, alias);
          }
      

      In practice AggregateCall constructor has null checks, so aggregateCall would always throw NPE:

          this.type = Objects.requireNonNull(type);
          this.collation = Objects.requireNonNull(collation);
      

      julianhyde, would you please check if that behavior is expected?

      Attachments

        1. RelBuilder_aggregateCall.png
          81 kB
          Vladimir Sitnikov
        2. AggregateCall_init.png
          212 kB
          Vladimir Sitnikov
        3. AggregateCall_create.png
          158 kB
          Vladimir Sitnikov

        Issue Links

          Activity

            People

              julianhyde Julian Hyde
              vladimirsitnikov Vladimir Sitnikov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: