Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4079

Dialect constants in SqlDialect can cause class initialization deadlock

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.23.0
    • Fix Version/s: 1.25.0
    • Component/s: core

      Description

      /** @deprecated Use {@link AnsiSqlDialect#DEFAULT} instead. */
      @Deprecated // to be removed before 2.0
      public static final SqlDialect DUMMY =
          AnsiSqlDialect.DEFAULT;
      
      /** @deprecated Use {@link CalciteSqlDialect#DEFAULT} instead. */
      @Deprecated // to be removed before 2.0
      public static final SqlDialect CALCITE =
          CalciteSqlDialect.DEFAULT;

      SqlDialect#DUMMY and SqlDialect#CALCITE are marked deprecated and have not be used in any places.
      It would be better to remove them to avoid class initialization deadlock.

        Attachments

        1. CALCITE-4079.01.patch
          2 kB
          Stamatis Zampetakis
        2. image-2020-07-01-19-51-32-397.png
          121 kB
          TANG Wen-hui
        3. image-2020-07-01-19-27-25-354.png
          6 kB
          TANG Wen-hui

          Issue Links

            Activity

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                winipanda TANG Wen-hui
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m