[CALCITE-4079] Dialect constants in SqlDialect can cause class initialization deadlock

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.23.0
• Fix Version/s: 1.25.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Julian Hyde
• Reporter: TANG Wen-hui
• Created: 22/Jun/20 11:49
• Updated: 22/Aug/20 18:48
• Resolved: 29/Jul/20 01:11

Description

/** @deprecated Use {@link AnsiSqlDialect#DEFAULT} instead. */
@Deprecated // to be removed before 2.0
public static final SqlDialect DUMMY =
    AnsiSqlDialect.DEFAULT;

/** @deprecated Use {@link CalciteSqlDialect#DEFAULT} instead. */
@Deprecated // to be removed before 2.0
public static final SqlDialect CALCITE =
    CalciteSqlDialect.DEFAULT;

SqlDialect#DUMMY and SqlDialect#CALCITE are marked deprecated and have not be used in any places.
It would be better to remove them to avoid class initialization deadlock.

Issue Links

• is blocked by: CALCITE-4117 Release Calcite 1.24.0
• is related to: CALCITE-3923 Refactor how planner rules are parameterized
• relates to: CALCITE-4136 ReduceExpressionsRule.FILTER_INSTANCE cannot be initialized by some JVM
• links to: GitHub Pull Request #2040