[CALCITE-3469] Wrong rel used in SubstitutionVisitor#rowTypesAreEquivalent

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: daimin
• Created: 01/Nov/19 07:24
• Updated: 06/Mar/20 04:36
• Resolved: 09/Nov/19 19:04

Description

  private boolean rowTypesAreEquivalent(
      MutableRel rel0, MutableRel rel1, Litmus litmus) {
    if (rel0.rowType.getFieldCount() != rel1.rowType.getFieldCount()) {
      return litmus.fail("Mismatch for column count: [{}]", Pair.of(rel0, rel1));
    }
    for (Pair<RelDataTypeField, RelDataTypeField> pair
        : Pair.zip(rel0.rowType.getFieldList(), rel0.rowType.getFieldList())) {
      if (!pair.left.getType().equals(pair.right.getType())) {
        return litmus.fail("Mismatch for column type: [{}]", Pair.of(rel0, rel1));
      }
    }
    return litmus.succeed();
  }

Where

Pair.zip(rel0.rowType.getFieldList(), rel0.rowType.getFieldList())

should be

Pair.zip(rel0.rowType.getFieldList(), rel1.rowType.getFieldList())

Issue Links

• relates to: CALCITE-3113 Equivalent MutableAggregates with different row types fail with AssertionError
• links to: GitHub Pull Request #1555