[CALCITE-3113] Equivalent MutableAggregates with different row types fail with AssertionError

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.19.0
• Fix Version/s: 1.21.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: Feng Zhu
• Created: 06/Jun/19 06:51
• Updated: 01/Nov/19 07:27
• Resolved: 17/Jul/19 10:36

Description

Add test case in MaterializationTest:

@Test public void testAggregateAlias() {
  checkMaterialize(
      "select count(*) as c from \"emps\" group by \"empid\"",
      "select count(*) + 1 as c from \"emps\" group by \"empid\"");
}

 It fails due to different rowtype.

java.lang.AssertionError
    at org.apache.calcite.plan.SubstitutionVisitor.go(SubstitutionVisitor.java:504)
    at org.apache.calcite.plan.SubstitutionVisitor.go(SubstitutionVisitor.java:465)
    at org.apache.calcite.plan.MaterializedViewSubstitutionVisitor.go(MaterializedViewSubstitutionVisitor.java:56)
    at org.apache.calcite.plan.RelOptMaterializations.substitute(RelOptMaterializations.java:200)
    at org.apache.calcite.plan.RelOptMaterializations.useMaterializedViews(RelOptMaterializations.java:72)
    at org.apache.calcite.plan.volcano.VolcanoPlanner.registerMaterializations(VolcanoPlanner.java:347)

However, according to MutableAggregate's hashCode&equals implementation, this materialization can be reused, i.e., queryDescedant=targetDescendant.

queryDescendant: RecordType(JavaType(int) empid, BIGINT $f1)
=============================================================================
Aggregate(groupSet: {0}, groupSets: [{0}], calls: [COUNT()])
  Project(projects: [$0])
    Scan(table: [hr, emps])

targetDescendant: RecordType(JavaType(int) empid, BIGINT C)
=============================================================================
Aggregate(groupSet: {0}, groupSets: [{0}], calls: [COUNT()])
  Project(projects: [$0])
    Scan(table: [hr, emps])

So, how can we align them?

 

Issue Links

• is related to: CALCITE-3469 Wrong rel used in SubstitutionVisitor#rowTypesAreEquivalent
• relates to: CALCITE-3182 Trim unused fields for plan of materialized-view before matching.
• links to: GitHub Pull Request #1310