[CALCITE-3447] Fix equivalents in method SubstitutionVisitor#go

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.23.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Jin Xing
• Reporter: daimin
• Created: 25/Oct/19 09:57
• Updated: 24/May/20 11:59
• Resolved: 20/Apr/20 12:37

Description

Code segment here depends on `hashcode` and `equals` methods of class `MutableRel`:

https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java#L492-L502 

However the implementations of class `MutableScan` delegates to class `TableScan`, which directly relies on implementations of class `Object`. This leads to a situation that two `MutableScan` on the exactly same table will not be considered as equivalent.

Issue Links

• relates to: CALCITE-3167 Remove overriding equals and hashCode methods in EnumerableTableScan
• links to: GitHub Pull Request #1531
• links to: GitHub Pull Request #1926